Feat: add support for Duration for AWS Assume Roles in env0_aws_crede… #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I see only test that is updated with duration.
Can you test also creation with duration please?
And also create and update with illegal values?
If these cases are tested somewhere else please point me there
There was a problem hiding this comment.
Happy to add these.
I'll do it a bit later today.
There was a problem hiding this comment.
@sagilaufer1992 sorry for the delay.
I have added the requested use-cases.
sagilaufer1992
approved these changes
Sep 27, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntials resource
Issue & Steps to Reproduce / Feature Request
resolves #710
Solution